Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix linker error and lower Boost version in Follow Me example #256

Merged
merged 1 commit into from
Feb 13, 2018
Merged

Fix linker error and lower Boost version in Follow Me example #256

merged 1 commit into from
Feb 13, 2018

Conversation

shakthi-prashanth-m
Copy link
Contributor

  • Fix linker error occurred during flexible plugin arch changes.
  • Lower Boost dependency version from 1.66 to 1.58 to match on Ubuntu 16.

Related: (dronecore/docs/#94)

Fix linker error and lower Boost version in Follow Me example
7d6c67c 
1. Fix linker error occured during flexible plugin arch changes.
2. Lower Boost dependency version from `1.66` to `1.58` to match
   that of Ubuntu 16.
@hamishwillee
Copy link
Collaborator

Thanks @shakthi-prashanth-m - I will look at this early next week.

hamishwillee
hamishwillee reviewed Feb 13, 2018
View reviewed changes
Copy link
Collaborator

@hamishwillee hamishwillee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, but not really appropriate for me to make technical review.

julianoes
julianoes approved these changes Feb 13, 2018
View reviewed changes
Copy link
Collaborator

@julianoes julianoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, seems good.

@julianoes julianoes merged commit 810a313 into develop Feb 13, 2018
@julianoes julianoes deleted the fix-follow-me-boost-dep branch February 13, 2018 14:44
@hamishwillee
Copy link
Collaborator

Thanks!

@hamishwillee hamishwillee mentioned this pull request Feb 14, 2018
Merged
@mrpollo mrpollo mentioned this pull request Jun 5, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hamishwillee hamishwillee hamishwillee left review comments

@JonasVautherin JonasVautherin JonasVautherin approved these changes

@julianoes julianoes julianoes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@shakthi-prashanth-m @hamishwillee @julianoes @JonasVautherin